Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor/simple: prohibit setting a resource group to a role (#54525) #54551

Merged
merged 1 commit into from
Jul 15, 2024
Merged

executor/simple: prohibit setting a resource group to a role (#54525) #54551

merged 1 commit into from
Jul 15, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #54525

What problem does this PR solve?

Issue Number: close #54417, ref #54434.

What changed and how does it work?

Check if a user is a role before assigning a resource group to it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
image

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@JmPotato @ti-chi-bot
Prohibit setting a resource group to a role
35aa59d 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 10, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 10, 2024
Merged
3 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 10, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/cherry-pick-not-approved labels Jul 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@b90e57a). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.1     #54551   +/-   ##
================================================
  Coverage               ?   71.3051%           
================================================
  Files                  ?       1465           
  Lines                  ?     422281           
  Branches               ?          0           
================================================
  Hits                   ?     301108           
  Misses                 ?     100750           
  Partials               ?      20423
Flag Coverage Δ
unit 71.3051% <33.3333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.0456% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-10 09:47:43.345913809 +0000 UTC m=+437360.581147922: ☑️ agreed by JmPotato.
  • 2024-07-11 02:16:54.34487841 +0000 UTC m=+496711.580112523: ☑️ agreed by nolouch.

@nolouch
Copy link
Member

nolouch commented Jul 12, 2024

/retest-required

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 15, 2024
@JmPotato
Copy link
Member

/test build

@tiprow tiprow
Copy link

tiprow bot commented Jul 15, 2024

@JmPotato: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit ae394c6 into pingcap:release-8.1 Jul 15, 2024
18 checks passed
@JmPotato JmPotato deleted the cherry-pick-54525-to-release-8.1 branch July 15, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees

@nolouch nolouch

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @nolouch @JmPotato @tangenta